Eternium
Eternium

Announcement

Collapse
No announcement yet.

[BUG / RFI] Rounding jewelry values

Collapse
X
  • Filter
  • Time
  • Show
Clear All
new posts

  • #16
    adjacentengels : algebra = Nhat : C
    VUFO ZEBE ZAQI 1381 -|- Gethi, mage, & Kisheli, XP mage

    Comment


    • #17
      One minor issue with the 144 to 180 range, the Life Regen 57 to 72 does not go into it properly.

      144 / 57 = 2.5263
      180 / 72 = 2.5

      So different ratio...
      Eternium Files - links and details (Updated: 10 Aug 2018)

      Eternium Guides:

      Comment


      • #18
        2.51 displays as 57-72 with rounding IIRC. JohnsonKorpo may still have the server sync message transcript with the actual factors

        Comment


        • #19
          JohnsonKorpo do you?
          VUFO ZEBE ZAQI 1381 -|- Gethi, mage, & Kisheli, XP mage

          Comment


          • #20
            Been testing this in game, got one result that disprove the scaling - I just realised it now, so I've unfortunately sold the test pieces, will try again once I get more gold, and lucky enough to get the XP/CD pieces.


            XP: 39.2 + 39.0 + 37.0 => 51.4

            * Minimum possible for rounded display above: 39.151 + 38.951 + 36.951
            => 51.50332
            Display: 51.5% <= higher than in game.

            * 144-180, Scale 4, floor: 156 + 156 + 148
            => 205.33333
            Display: 51.3% <= lower than in game

            Taking highest possible value for rounded stats: 39.249 + 39.049 + 37.049
            Which gives you the internal values of: 156.996 + 156.196 + 148.196
            Still FLOOR to the same values above, which means we're still slightly off.


            4 other tests resulted in the same fused values as that calculated with the internal 144-180 value, using item's stat minimum always resulted in higher value than in game.
            Last edited by Nhat; 12-29-2017, 10:42 PM.
            Eternium Files - links and details (Updated: 10 Aug 2018)

            Eternium Guides:

            Comment


            • #21
              Jose Sarmento Coda the factors are hardcoded into the game. What flies in the network are the real stat values. 164.8 life regen corresponds to 66 display value, so 2.5 scaling factor would make sense, but if the min real value is 144 (which might not be the case), then 144 / 2.5 = 57.6 which rounds to 58, so the factor is probably a little larger (something around 2.51), because otherwise it wouldn't be possible to obtain 57 regen (and I'm assuming it is).

              Comment


              • #22
                Nhat

                ^^
                VUFO ZEBE ZAQI 1381 -|- Gethi, mage, & Kisheli, XP mage

                Comment


                • #23
                  New year update of in game testing, conclusions so far:

                  1. Existing calculation, using minimum stat values for LoH, CD & XP generally resulted in higher than in game.
                  2. With some exception for XP - calculations using 144-180 matches that of in game values.
                  3. The Ratings seems fine either way, (maybe due to the small rounding/scaling factor)

                  Not enough details to draw any conclusions for Armor and Life Regen yet - I'm assuming Gold will be similar to XP, since it's the same scaling and range.


                  Test spreadsheet - feel free to copy and add any test data you have, I'll keep updating it as I go...

                  Screen shots confirming the variation for XP:
                  Click image for larger version

Name:	Screenshot_2018-01-01-13-11-53.png
Views:	51
Size:	285.2 KB
ID:	79367Click image for larger version

Name:	Screenshot_2018-01-01-13-11-55.png
Views:	19
Size:	282.7 KB
ID:	79368Click image for larger version

Name:	Screenshot_2018-01-01-13-11-58.png
Views:	22
Size:	281.5 KB
ID:	79369Click image for larger version

Name:	Screenshot_2018-01-01-13-12-01.png
Views:	22
Size:	282.8 KB
ID:	79370
                  Eternium Files - links and details (Updated: 10 Aug 2018)

                  Eternium Guides:

                  Comment


                  • #24
                    Something I've been testing with, given how a number of results using the internal 144-180 scaled values were lower than that in the game.

                    What if the formula was:
                    => (1 + Bonus) * (FLOOR(MAX(j1, j2, j3)) + SUM(j1, j2, j3) / 15)


                    Retesting existing error values:

                    1. CD: 3x 59.9% => game fused as 78.8%
                    Min possible: 59.851% => 79% (wrong)
                    Scaled and Floored: 179 => 78.8% (correct, 78.76)
                    Scaled, max floored: 179.7 => 78.8% (correct, 78.81)


                    2. Had an incorrect Vitality previously as well:
                    73 + 85 + 72 => game fused as 111
                    Using stats: max 73.49 + 85.49 + 72.49 => 111.0 (correct)
                    Scaled and floored: max 146 + 170 + 144 => 110.4 (wrong)
                    Scaled, max floored: max 146.98 + 170.98 + 144.98 => 110.5 (which will display 111)


                    3. XP: 44.9% + 44.5% + 44.6% => game fused 59.1%
                    Using stats: min 44.851 + 44.451 + 44.551 => 59.15% (round to 59.2%, wrong)
                    Scaled and floored: max 179 + 178 + 178 => 59.03% (round to 59.0% also wrong)
                    Scaled, max floored: 179.6 + 178 + 178.4 => 59.05% (round to 59.1%, correct)


                    Will retest all previous values to see if there's anything opposed to this, but I think this is the more correct formula, and it's easily caused by having the MAX function returning an integer rather than a float.
                    Eternium Files - links and details (Updated: 10 Aug 2018)

                    Eternium Guides:

                    Comment


                    • #25
                      You do good work. Much appreciated.

                      Comment


                      • #26
                        Originally posted by Nhat View Post
                        2. Had an incorrect Vitality previously as well:
                        73 + 85 + 72 => game fused as 111
                        Using stats: max 73.49 + 85.49 + 72.49 => 111.0 (correct)
                        Scaled and floored: max 146 + 170 + 144 => 110.4 (wrong)
                        Scaled, max floored: max 146.98 + 170.98 + 144.98 => 110.5 (which will display 111)
                        Got this one wrong, sorry. Even with the revised formula, the calculated value would still be rounded to "110"
                        I was using the already rounded "110.5" previously.
                        Click image for larger version

Name:	test.png
Views:	21
Size:	77.0 KB
ID:	79503


                        This is the only one in my tests that still doesn't fit with the revised formula. All XP & CD fusing that were outside the min/max range for the scaling are now correct with the revised formula.

                        Will keep adding to the test data, any additional data points are appreciated - I've updated the test spreadsheet to include the new calculation and results.
                        Eternium Files - links and details (Updated: 10 Aug 2018)

                        Eternium Guides:

                        Comment


                        • #27
                          Jose Sarmento ^^

                          (Nice work Nhat !! )
                          VUFO ZEBE ZAQI 1381 -|- Gethi, mage, & Kisheli, XP mage

                          Comment


                          • #28
                            Nice work indeed!

                            Nhat If you can keep those rings and would be OK with setting up a packet inspector (*inspecting* network traffic is quite legitimate; *tampering* with packet contents is what wouldn't be), maybe JohnsonKorpo can guide you into obtaining their actual internal value as it is sent to/from the game server. That should clarify the remaining incongruency I think.

                            Also, the max internal value that would show as 72 is 145 (divide by 2 = 72.5, still rounds to 72 as per rules for rounding odd vs. even numbers). Not that it explains the incongruency.

                            Comment


                            • #29
                              Originally posted by Jose Sarmento View Post
                              Nhat If you can keep those rings and would be OK with setting up a packet inspector (*inspecting* network traffic is quite legitimate; *tampering* with packet contents is what wouldn't be), maybe JohnsonKorpo can guide you into obtaining their actual internal value as it is sent to/from the game server. That should clarify the remaining incongruency I think.
                              Only saw the issue when I was retesting, so already sold them (no room to keep them all), and don't have screenshots either - only took it for things falling outside the results range. I'm still crafting for me perfect set, so hoping to reproduce them. If it doesn't happen again after 100 results, I'll consider it as a typo - "0" and "1" are close together on the numpad...

                              Also want to get data for Armor and Regen before I go updating my crafting spreadsheet, Gold falls into the same range as XP, so I consider that covered already.

                              I'll leave it to the dev to confirm/deny the range, not comfortable with tracing other people's programs. We got one data point for that, and it's within the currently expected range, so I think it's safe to go with it, also because of the consistency of current collected data, aside from the one exception...
                              Eternium Files - links and details (Updated: 10 Aug 2018)

                              Eternium Guides:

                              Comment


                              • #30
                                (Slightly off topic)

                                Another thing, with respect to the "packet inspector" thing, Jewelry crafting and fusing can be done completely offline - which I've done quite a few times already. Which means there's nothing sent between the device and server for them.

                                So this would only apply to Item crafting/reforging? Haven't been doing either of that, so don't know...
                                Eternium Files - links and details (Updated: 10 Aug 2018)

                                Eternium Guides:

                                Comment

                                Working...
                                X